flux-pr-2185
sqlparser-rs (Rust) · W2 · GPT-5.4
Tests passed. 1/1 commands passed. Strength: strong.
env PATH=/root/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin cargo test --all-featuresPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The patch partially implements the feature (NOCYCLE and CONNECT_BY_ROOT) but likely does not satisfy the intended hierarchical-query redesign, and it introduces regression risk by removing generic select-item prefix handling.
The patch keeps a single `ConnectBy` struct with optional `condition` instead of modeling `START WITH` and `CONNECT BY` as independent clause kinds, so clause ordering and structure are not represented as required by the intended Oracle 21c-aligned change.
Previous generic prefix handling in `parse_select_item` was deleted and replaced with a CONNECT_BY_ROOT-specific parser branch. This can break or block other dialect-specific reserved select-item operators that depended on the generic mechanism.
Because `START WITH` is stored as an optional field on one struct and emitted before `CONNECT BY`, input clause order is normalized rather than represented, which weakens support for order-flexible syntax semantics and round-trip fidelity.