flux-pr-2011
sqlparser-rs (Rust) · W2 · GPT-5.3 Codex
Tests passed. 1/1 commands passed. Strength: strong.
env PATH=/root/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin cargo test --all-featuresPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Core features were added (MERGE as `SetExpr`, `RETURNING`, optional `INTO`, and tests), but `OutputClause` display behavior is functionally off: in `src/ast/mod.rs`, it prints `" INTO {into_table}"` even though `SelectInto` is already the `INTO ...` clause in existing design (gold keeps `into_table` formatting without prepending `INTO`). This risks rendering `OUTPUT ... INTO` incorrectly (e.g., duplicated `INTO`) and is not equivalent behavior.
Code Review
The patch substantially implements the requested MERGE-as-query-body and OUTPUT/RETURNING support, but it likely does not fully satisfy intent because it accepts and can render `RETURNING ... INTO`, a materially incorrect grammar combination.
After parsing either OUTPUT or RETURNING, the code unconditionally accepts optional INTO. This permits invalid PostgreSQL-style syntax (`RETURNING ... INTO`) and the formatter will emit that form as well.