STET

flux-pr-1262

graphql-go-tools (Go) · W1 · GPT-5.1 Codex Mini

pass_with_warn

Tests passed. 1/1 commands passed. Strength: strong.

57.1% run pass rate
Tier 1
primary testspassednon equivalentdecision conflictfail
go test -C v2 ./... -count=1 -timeout=300s
gold passagent pass

Partial score: 1/1

Publishable: noCache: miss

Trajectory

codex · partial order only

provider-native trajectory captured; validation and decision steps are appended with coarse ordering only

session start
Session started
#1
tool call
Command started
#2

shell command

tool result
Command finished
#3

shell command exit code 0

tool call
Command started
#4

shell command

tool result
Command finished
#5

shell command exit code 0

tool call
Command started
#6

shell command

tool result
Command finished
#7

shell command exit code 1

tool call
Command started
#8

shell command

tool result
Command finished
#9

shell command exit code 0

tool call
Command started
#10

shell command

tool result
Command finished
#11

shell command exit code 0

tool call
Command started
#12

shell command

tool result
Command finished
#13

shell command exit code 0

tool call
Command started
#14

shell command

tool result
Command finished
#15

shell command exit code 0

tool call
Command started
#16

shell command

tool result
Command finished
#17

shell command exit code 0

tool call
Command started
#18

shell command

tool result
Command finished
#19

shell command exit code 0

tool call
Command started
#20

shell command

tool result
Command finished
#21

shell command exit code 0

tool call
Command started
#22

shell command

tool result
Command finished
#23

shell command exit code 0

tool call
Command started
#24

shell command

tool result
Command finished
#25

shell command exit code 0

tool call
Command started
#26

shell command

tool result
Command finished
#27

shell command exit code 0

tool call
Command started
#28

shell command

tool result
Command finished
#29

shell command exit code 0

tool call
Command started
#30

shell command

tool result
Command finished
#31

shell command exit code 0

tool call
Command started
#32

shell command

tool result
Command finished
#33

shell command exit code 0

tool call
Command started
#34

shell command

tool result
Command finished
#35

shell command exit code 0

tool call
Command started
#36

shell command

tool result
Command finished
#37

shell command exit code 1

tool call
Command started
#38

shell command

tool result
Command finished
#39

shell command exit code 0

tool call
Command started
#40

shell command

tool result
Command finished
#41

shell command exit code 0

tool call
Command started
#42

shell command

tool result
Command finished
#43

shell command exit code 0

tool call
Command started
#44

shell command

tool result
Command finished
#45

shell command exit code 0

tool call
Command started
#46

shell command

tool result
Command finished
#47

shell command exit code 0

tool call
Command started
#48

shell command

patch written
Patch captured
#49

Flux captured agent.patch for this trial

validation
Tests passed
#50

go

equivalence
Equivalence judgment
#51

non_equivalent

code review
Code review judgment
#52

fail

decision
Final decision
#53

pass_with_warn

Quality

equivalence
non_equivalent
95% confidence
code review
fail · 25/100
4 findings
footprint
low (0.14)
behavioral
100.0%
cost

Equivalence Reasoning

behavioral

Code Review

correctness: 1/4edge case handling: 1/4introduced bug risk: 1/4maintainability idioms: 1/4

The patch likely does not satisfy the intended refactor. It changes config types and tests, but core federation planning still appears single-context and lacks robust key handling and safe per-fragment call construction needed for correct multi-entity/parallel behavior.

4 findings
Multiple entity fragments are still planned through a single call context
major

The visitor scaffolds once and does not create distinct calls per inline fragment/entity type. `resolveEntityInformation` only fully configures call metadata on first entity (`configureCall := entityInfo.name == ""`), so later entity fragments are not independently planned as required.

v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go:270
RPC selection can silently use wrong key mapping
major

If no exact key match is found, the implementation falls back to the first entity RPC config (`selectedConfig = &configs[0]`). This can route lookups to the wrong RPC for multi-key entities.

v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go:680
Federation key parsing is not robust for structured keys
major

Key fields are parsed using `strings.Fields(fieldsStr)`, which does not preserve nested/key selection semantics used by federation keys. This risks incorrect key field extraction and request shaping.

v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go:661
Inline fragment lifecycle cleanup removed
major

`LeaveInlineFragment` became a no-op while shared entity state remains mutable. This raises risk that later fragments or fields observe stale entity planning state.

v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go:284