flux-pr-1262
graphql-go-tools (Go) · W1 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The patch likely does not satisfy the intended refactor. It changes config types and tests, but core federation planning still appears single-context and lacks robust key handling and safe per-fragment call construction needed for correct multi-entity/parallel behavior.
The visitor scaffolds once and does not create distinct calls per inline fragment/entity type. `resolveEntityInformation` only fully configures call metadata on first entity (`configureCall := entityInfo.name == ""`), so later entity fragments are not independently planned as required.
If no exact key match is found, the implementation falls back to the first entity RPC config (`selectedConfig = &configs[0]`). This can route lookups to the wrong RPC for multi-key entities.
Key fields are parsed using `strings.Fields(fieldsStr)`, which does not preserve nested/key selection semantics used by federation keys. This risks incorrect key field extraction and request shaping.
`LeaveInlineFragment` became a no-op while shared entity state remains mutable. This raises risk that later fragments or fields observe stale entity planning state.