flux-pr-1351
graphql-go-tools (Go) · W1 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch does add grouped storage and deterministic joining, but it misses core intended behavior for per-subgraph attribution in loader hook responses: `newResponseInfo` call sites now pass `ctx.SubgraphErrors()` (the global joined error), so `ResponseInfo.Err` is still not scoped to the current subgraph. The gold intent is to provide each response with its own subgraph’s error (`subgraphErrors[res.ds.Name]`). Also, the new grouped store appears to be map-backed without clone deep-copy updates, which can cause aliasing across cloned contexts.
Code Review
The patch mostly implements grouped subgraph error storage and deterministic ordering, but a key integration point still appears to propagate aggregated errors to loader hook response info, so it likely does not fully satisfy the intended per-subgraph attribution change.
`newResponseInfo` call sites were switched to pass `l.ctx.SubgraphErrors()`, which is the aggregate joined error, so `ResponseInfo.Err` can still represent all subgraphs rather than the current result subgraph. This conflicts with the intended per-subgraph attribution behavior.