flux-pr-1087
graphql-go-tools (Go) · W1 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch captures the parent-walk boundary fix, but it misses core intent in two places: (1) it adds the new permutations package at `pkg/testing/permutations` instead of `v2/pkg/testing/permutations` while importing `.../v2/pkg/testing/permutations`, which is a functional path mismatch; and (2) `allKeysHasDisabledEntityResolver` now returns `false` when the *filtered* key set is empty (for a given type), which is broader than the intended fix (only when datasource has zero federation keys overall).
Code Review
The patch partially addresses the two planner bugs, but it likely fails the intended change due to a major package-path mismatch for the new permutations utility and a non-equivalent parent-selection implementation compared with the expected helper-based fix.
`datasourcetesting` imports `github.com/wundergraph/graphql-go-tools/v2/pkg/testing/permutations`, but the patch adds `pkg/testing/permutations/permutations.go` instead of `v2/pkg/testing/permutations/permutations.go`, which likely causes unresolved import/build failure.
The intended fix uses `selectWithExternalCheck(...)` and stops when that helper rejects selection. This patch inlines only `IsExternal && !IsProvided` and then directly calls `selectWithReason`, which may skip other helper logic and can alter selection behavior across datasource boundaries.