flux-pr-1169
graphql-go-tools (Go) · W1 · GPT-5.1 Codex Mini
Tests: unknown. 0/1 commands passed. Strength: missing.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 0/0
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The agent patch partially updates message text and locations, but it likely does not satisfy the intended PR: key spec-compliant field-selection behaviors and the new centralized Apollo validation-failed mechanism are not correctly implemented.
Validation only rejects sub-selections for scalar fields (`NodeKindScalarTypeDefinition`) and does not reject enum fields with selections, which should also be treated as leaf types.
The call passes `typeName` (enclosing type) into `ErrMissingFieldSelectionOnNonScalar`, but the spec-style message expects the field's return type (e.g., `User`, `User!`, `[User]`). This can produce incorrect error text.
Status/extension codes are applied in `Validate` only when `ReplaceUndefinedOpFieldError` is set, rather than via a centralized walker-level external-error hook with the new dedicated compatibility flag. This keeps old flag semantics and misses the intended architecture change.