flux-pr-1169
graphql-go-tools (Go) · W2 · GPT-5.3 Codex
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch captures part of the intent (spec-like field-selection messages and adding locations), but it misses core behavior: it drops `DefaultOperationValidator` option processing entirely (so Apollo compatibility flags no longer work), applies validation metadata unconditionally instead of via the new centralized compatibility mechanism/flag, and differs in error-location semantics (uses field position rather than selection-set brace for leaf-selection errors). It also omits at least one message alignment present in the intended change (e.g., inline fragment mismatch text).
Code Review
The agent patch only partially matches the intended PR and introduces behavioral regressions: options are no longer applied in validator construction, scalar field-selection validation remains semantically off, and validation metadata is applied unconditionally rather than via centralized compatibility control.
The constructor removed the options accumulation loop, so Option inputs are ignored. This breaks compatibility-flag driven behavior and changes API semantics beyond the stated scope.
EnterField still routes scalar enclosing types to ValidateScalarField, which returns a leaf-selection error. For selecting a field on a scalar parent type, GraphQL semantics expect an undefined-field style error on that type.
applyValidationErrorMetadata is always invoked when any validation error exists, so ExtensionCode and StatusCode are overwritten by default. This removes prior opt-in behavior and can alter consumers expecting legacy error envelopes.
The prior test matrix validating both true/false Apollo compatibility propagation was replaced by a single always-on expectation, reducing regression protection for option-driven behavior.