flux-pr-1308
graphql-go-tools (Go) · W2 · GPT-5.3 Codex
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch appears to add schema/introspection surface changes and some operation-level/error-location updates, but it does not clearly implement the full required behavior, especially OneOf enforcement in runtime variable validation (`variablesvalidation`) and directive exposure in all expected introspection outputs. It also introduces `isOneOf`-centric introspection changes that differ from the stated intent of exposing the `@oneOf` directive itself.
Code Review
The patch appears only partially aligned and likely does not satisfy the intended OneOf feature set end-to-end; core validation behavior and introspection direction differ from the requested change.
The shown change in `operation_rule_values.go` only introduces a directive-name constant and does not include OneOf enforcement (exactly one field, non-null, nullable-variable checks) required by the task.
The patch modifies `__Type` selections/fixtures to include `isOneOf`; requested behavior is to expose/support `@oneOf` as a built-in directive in schema/introspection, so this is likely misaligned with intended API output.
The task requires validation at runtime variables level as well; the provided diff excerpt does not show corresponding `variablesvalidation` OneOf checks, leaving key edge cases uncovered.
The directive is added without the descriptive doc string, which can desynchronize generated schema/introspection descriptions from expected outputs and reduce compatibility with existing golden expectations.