flux-pr-1184
graphql-go-tools (Go) · W2 · GPT-5.4
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The patch is directionally correct and likely fixes several failing cases, but it does not fully match the intended rewrite semantics; key correctness gaps remain in union rewrite gating and recursive fragment flattening behavior.
The union cleanup check was added, but it sits after the pre-existing flow where union rewrite decisions may return before evaluating union fragments when no interface fragments are present. This can miss required rewrites for selections that rely on union nested fragments.
In `flattenFragmentOnUnion`, object inline fragments are copied directly (`CopySelection`) rather than recursively flattened through nested abstract fragments. This can preserve invalid nested structure instead of rewriting to concrete-type fragments.
The helper now supports parent-valid-type checks, but the main interface/union rewrite decision flow was not fully switched to the new object cleanup strategy, leaving paths that still rely on datasource existence checks and can miss parent-membership filtering.