flux-pr-1169
graphql-go-tools (Go) · W2 · GPT-5.4
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The patch likely does not satisfy the intended PR behavior: it updates several messages and locations, but misses the intended centralized validator-level compatibility mechanism and introduces broader error-conversion behavior changes with regression risk.
`WithApolloCompatibilityFlags` discards the provided flags, so validator behavior can no longer be controlled via compatibility options as intended.
The change applies `GRAPHQL_VALIDATION_FAILED` through specific response-conversion call sites instead of centrally in validation error generation, so behavior is not uniformly enforced across all validator consumers.
The refactor removed the prior early-continue path and now sets `Extensions.Code` whenever an external error has one, even when status override is disabled; this broadens behavior outside the validation-only intent.