flux-pr-1308
graphql-go-tools (Go) · W2 · GPT-5.4
Tests failed. 0/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 0/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
Code Review
The agent patch likely does not satisfy the intended PR. It adds partial schema/introspection/testing scaffolding, but the critical operation and variable oneOf enforcement and requested undefined-variable position behavior appear incomplete or mismatched.
In the shown changes, `operation_rule_values.go` only adds a directive-name constant, but the required runtime rule enforcement (exactly one field, non-null, variable nullability checks) is not visible. This likely leaves oneOf operation validation incomplete.
The visible diff in `variablesvalidation.go` adds only `oneOfDirectiveName`; enforcement logic for oneOf variable payloads is not shown there, despite new tests expecting such behavior.
The patch changes `operation_rule_all_variable_uses_defined.go` to pass a position into `ErrVariableNotDefinedOnArgument`, but the requested change centers on operation value validation paths and `ErrVariableNotDefinedOnOperation` with source location. This suggests behavior mismatch.
The patch adds `IsOneOf` to model types and a constant in generator, but the visible generator logic to set `isOneOf` is absent. Added tests/fixtures imply this field should be populated consistently.
The patch uses alternate one-line wording for `@oneOf` description and custom error strings; this can cause fixture drift and inconsistent UX vs the intended text across schema/introspection outputs.