flux-pr-1169
graphql-go-tools (Go) · W2 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch captures part of the intent (spec-like messages, added locations, centralized status/extension assignment), but it misses core behavior. In field-selection validation it still reports leaf-selection errors with the field name as the type (e.g., using `definitionName` instead of the actual GraphQL type like `String`), and it uses field position rather than selection-set brace position for that error location. It also removes validator options entirely, which likely breaks existing Apollo-compatibility flag flow (notably `ReplaceInvalidVarError`) instead of centralizing while preserving other flag behavior.
Code Review
The patch passes tests but likely does not satisfy the intended change set: it removes configurable compatibility plumbing, applies validation metadata too broadly, and still misses key spec-format error details.
The change removes `ReplaceUndefinedOpFieldError` and also removes validator option plumbing entirely, but does not introduce the new `UseGraphQLValidationFailedStatus` compatibility flag pathway. This diverges from the intended configurable centralized mechanism and changes public validator construction behavior.
The walker now assigns `GRAPHQL_VALIDATION_FAILED` and HTTP 400 for any external error missing those fields. This is broader than validation-rule errors and is not gated by compatibility options, creating behavior drift and potential unintended status/code changes.
Missing-subselection errors omit the expected `Did you mean "X { ... }"?` suffix, and leaf-selection errors use generic field position-derived locations rather than dedicated selection-set brace locations, so output is still inconsistent with the intended canonical formatting.