flux-pr-1351
graphql-go-tools (Go) · W2 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The patch largely implements per-subgraph grouping and deterministic joining, but it changes `subgraphErrors` to a mutable map+mutex wrapper without updating `Context.clone` to deep-copy that state. Cloned contexts can share subgraph error entries (and copy a used mutex), causing cross-context error leakage/race-prone behavior, which breaks intended resolution-context semantics.
Code Review
The patch likely satisfies the intended change (per-subgraph attribution plus deterministic combined output) and passes tests, but it introduces extra complexity and a minor ambiguity in name-based lookup behavior for duplicate datasource names.
The storage key allows multiple entries with the same datasource name (`ID+Name`), but `SubgraphErrorByName` scans a map and returns the first matching name/ID encountered. If two datasources share a name, returned error selection is order-dependent.