flux-pr-1308
graphql-go-tools (Go) · W2 · GPT-5.1 Codex Mini
Tests passed. 1/1 commands passed. Strength: strong.
go test -C v2 ./... -count=1 -timeout=300sPartial score: 1/1
Trajectory
codex · partial order onlyprovider-native trajectory captured; validation and decision steps are appended with coarse ordering only
Quality
Equivalence Reasoning
behavioral
The agent patch appears to only partially implement the feature: it adds `@oneOf` to base schema/fixtures and some variable-side helpers, but does not clearly include the full operation-level oneOf enforcement, nullable-variable-in-oneOf checks, or the undefined-variable error position/reporting changes required by the task. It also seems to change introspection shape (`isOneOf`) rather than clearly exposing the built-in `@oneOf` directive in directive introspection output.
Code Review
The agent patch likely does not satisfy the intended PR: it includes partial/schema-level edits and some unrelated introspection output changes, but misses core oneOf enforcement and undefined-variable-location behavior needed for correctness.
The operation values validator only adds a oneOf constant in the shown diff and does not include the required logic to enforce exactly one provided field, non-null value, and nullable-variable rejection at operation validation time.
The task requires improved undefined-variable errors with source locations; the shown patch does not update the error-construction API or operation validation flow to carry positions for this case.
The patch adds `isOneOf` to `FullType` and multiple golden outputs, which is a broader schema/output change than required and likely to break existing introspection expectations if not fully wired end-to-end.
Although helper logic was added in variables validation, the patch does not demonstrate the full expected behavior across both runtime variables and operation literals, especially nullable variable usage in oneOf fields.